feat: add push notifications #163
Open
+2,058
−280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reneaaron
force-pushed
the
feat/push-notifications
branch
from
0289ded to
1c6e544
Compare
feat: notification improvements
rolznz
reviewed
Jan 17, 2025
rolznz
reviewed
Jan 17, 2025
rolznz
reviewed
Jan 17, 2025
| @@ -67,6 +69,15 @@ export default function RootLayout() { | |||
| } | |||
| } | |||
|
|
|||
| async function checkAndPromptForNotifications() { | |||
| const isEnabled = useAppStore.getState().isNotificationsEnabled; | |||
| // prompt the user to enable notifications on first open | |||
There was a problem hiding this comment.
is this good UX? CC @reneaaron
rolznz
reviewed
Jan 17, 2025
rolznz
reviewed
Jan 17, 2025
|
Could you update the README to instruct devs how to run with expo go (notifications disabled) or natively (with notifications enabled) |
rolznz
reviewed
Jan 17, 2025
rolznz
reviewed
Jan 17, 2025
Done! Let me know if there are any changes. Luckily we have ExecutionEnvironment constant, so we can automatically detect if the user is running it in Expo Go and disable notifications. |
im-adithya
reviewed
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a todo about migrating wallet connections using 0.0 version to 1.0
NIP-44 decryption
Other TODOs
Stop notifications in iOS usingWe decided to show notifications for sending as well, so we don't have to wait for this nowusernotifications.filteringentitlement (also needs feat: add filtering option nikwebr/expo-notification-service-extension-plugin#1)Description
Testing
Replace
NOSTR_API_URLto local http-nostr urlRun feat: add endpoint for registering alby go notifications http-nostr#128 and use
ngrok http 8888Copy the ngrok link to NOSTR_API_URL in constants
If running on android, download
google-services.jsonfrom firebase console and add it to the root of your directory and set this in your .env.local:GOOGLE_SERVICES_JSON=./google-services.jsonConnect your device via cable and run yarn install and then
npx expo run:ios --device/npx expo run:android --deviceEnable notifications in settings and receive a transaction to get notified (tapping on the notification also switches to the right wallet and takes you to the transaction screen)